Skip to content

Adjust tab option margins for consistent spacing in ff-components#7301

Open
cstns wants to merge 1 commit into
mainfrom
ui/fix-horizontal-tab-options-active-bottom-border
Open

Adjust tab option margins for consistent spacing in ff-components#7301
cstns wants to merge 1 commit into
mainfrom
ui/fix-horizontal-tab-options-active-bottom-border

Conversation

@cstns
Copy link
Copy Markdown
Contributor

@cstns cstns commented May 19, 2026

Description

  • Adds margin-bottom to inactive horizontal tab options that matches the active tab's border-bottom width, then removes the margin when the tab becomes active keeping the total height of the tab bar constant
  • Scoped to .ff-tabs--horizontal only so vertical tabs are unaffected

Related Issue(s)

closes #7300

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this May 19, 2026
@cstns cstns requested a review from n-lark May 19, 2026 14:09
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.56%. Comparing base (f3c7282) to head (c896e57).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7301      +/-   ##
==========================================
+ Coverage   76.54%   76.56%   +0.01%     
==========================================
  Files         405      405              
  Lines       20591    20591              
  Branches     4977     4977              
==========================================
+ Hits        15761    15765       +4     
+ Misses       4830     4826       -4
Flag Coverage Δ
backend 76.56% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n-lark n-lark n-lark approved these changes

Assignees

@cstns cstns

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Horizontal tabs shift content when switching between active/inactive states

2 participants

@cstns @n-lark